Remove utf32 from encodings lists for MoarVM #4232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakudo currently lists utf32 as one of the encoding/decoding operations it supports. However, this support has never been added to the MoarVM backend and attempting to use it throws a somewhat confusing exception. Accordingly, this commit removes utf32 from relevant lists in Rakudo::Internals and Encoding::Registry when Rakudo is compiled for MoarVM (the JVM backend supports utf32). This causes spectest failures because Roast was checking whether an encoding was listed in the Encoding::Registry without testing whether the encoding could actually be used. I have prepared a companion PR that marks these tests as todo for rakudo.moar and that adds substests to ensure that registered encodings can actually be used.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rakudo currently lists utf32 as one of the encoding/decoding operations it supports. However, this support has never been added to the MoarVM backend and attempting to use it throws a somewhat confusing exception.
Accordingly, this commit removes utf32 from relevant lists in Rakudo::Internals and Encoding::Registry when Rakudo is compiled for MoarVM (the JVM backend supports utf32). This causes spectest failures because Roast was checking whether an encoding was listed in the Encoding::Registry without testing whether the encoding could actually be used.
I have prepared a companion PR that marks these tests as todo for rakudo.moar and that adds substests to ensure that registered encodings can actually be used.
Related issues: #3293 and MoarVM/MoarVM#1348