Make signal handler setup synchronous to avoid race conditions #4256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relies on MoarVM/MoarVM#1445 |
niner
force-pushed
the
signal_handler_setup_notification
branch
from
72f105c
to
fddb9d3
Compare
|
I updated the commit to use a Semaphore instead of the Promise and await. With this, signal handler setup will behave synchronously even when done as part of react/whenever setup, making Raku/roast@099d13e obsolete. |
lizmat
reviewed
Mar 21, 2021
src/core.c/signals.pm6
Outdated
| my $cancellation := nqp::signal($!scheduler.queue(:hint-time-sensitive), | ||
| my $queue := $!scheduler.queue(:hint-time-sensitive); | ||
| #?if moar | ||
| my $setup-semaphore = Semaphore.new(0); |
There was a problem hiding this comment.
:= perhaps? Saves one Scalar and indicates immutability?
niner
force-pushed
the
signal_handler_setup_notification
branch
from
fddb9d3
to
745466a
Compare
|
:= perhaps? Saves one Scalar and indicates immutability?
Right. Updated the commit.
|
On MoarVM setup of a signal handler is itself an asynchronous operation. Wait for it to complete before returning as not only our spec tests but probably every single user expects the signal handler to be in place at that point. This was already true for the JVM and JS backends. Fixes a race condition in t/spec/S17-procasync/kill.t
niner
force-pushed
the
signal_handler_setup_notification
branch
from
745466a
to
26a767c
Compare
|
Rebased and merged manually (to get the NQP bump in) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MoarVM setup of a signal handler is itself an asynchronous operation. Wait
for it to complete before returning as not only our spec tests but probably
every single user expects the signal handler to be in place at that point. This
was already true for the JVM and JS backends.
Fixes a race condition in t/spec/S17-procasync/kill.t