Add :max_threads(*|Inf) as option to ThreadPoolScheduler #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For those of us brave enough to not want to be stopped by a maximum number of OS threads. Specifying * or Inf will internally store the value 9223372036854775807 (aka the current maximum value for an uint attribute). The accessor will return Inf if this value is found.
vrurg
reviewed
May 21, 2022
| submethod TWEAK(:$initial_threads, :$max_threads --> Nil) { | ||
| $!initial_threads = .Int with $initial_threads; | ||
| $!max_threads = nqp::istype($max_threads,Whatever) | ||
| ?? 9223372036854775807 # XXX should be -1 |
There was a problem hiding this comment.
Just a suggestion. Perhaps, make the number a constant?
vrurg
reviewed
May 21, 2022
| ?? $max_threads == Inf | ||
| ?? 9223372036854775807 # XXX should be -1 | ||
| !! $max_threads.Int | ||
| !! (%*ENV<RAKUDO_MAX_THREADS> // (Kernel.cpu-cores * 8 max 64)).Int; |
There was a problem hiding this comment.
Also just a thought. Maybe set to "infinite" if the environment is -1 or just any negative? Could be helpful in detecting some problems too.
vrurg
approved these changes
May 21, 2022
vrurg
added a commit
that referenced
this pull request
Jun 3, 2022
Extending PR #4931. Aside of just setting `$!max_threads` to a specific number via `RAKUDO_MAX_THREADS` environment variable the following special cases are now supported too: - `RAKUDO_MAX_THREADS=` or `RAKUDO_MAX_THREADS=0` to use the default value - `RAKUDO_MAX_THREADS=-1`, `RAKUDO_MAX_THREADS=inf`, or `RAKUDO_MAX_THREADS=unlimited` to use unlimited number of treads - `RAKUDO_MAX_THREADS=<integer>` works as it always was - Any other value would result in an error Since a new scheduler is normally created at startup and exception handling is barely needed its constructor currently throws just `X::AdHoc`. Note that the above special cases are now also supported for constructor's `:max_threads` named argument: ThreadPoolScheduler.new(:max_threads(-1)); # Inf ThreadPoolScheduler.new(:max_threads<unlimited>); # Inf ThreadPoolScheduler.new(:max_threads(0)); # Same as omitting the # argument Super-micro-optimization: use of BUILDPLAN is considered too much for the `ThreadPoolScheduler` class. So, replaced it with `new`+`!SET-SELF` approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those of us brave enough to not want to be stopped by a maximum
number of OS threads. Specifying * or Inf will internally store the
value 9223372036854775807 (aka the current maximum value for an uint
attribute). The accessor will return Inf if this value is found.