Remove undocumented quotelang extenders #5436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary quotelang markers q, qq, and Q allow for a number of extenders according to the documentation: w, ww, and x. So instead of qw, one could also say q:w, and instead of qqww one could also say qq:ww. The grammar however **ALSO** allows for: to, s, a, h, f, c, b, o. Allowing one to say qqto and Qf (to name but two of the possible combinations). I think this is taking the TIMTOWTDO a little too far. So this commit removes support for these undocumented quotelang extenders. This breaks three spectest files: - t/spec/S02-literals/misc-interpolation.t - t/spec/S02-literals/quoting.t - t/spec/integration/advent2014-day16.t because they check for a, b and to as quotelang extenders respectively. If this change is OKd, then these tests will have to be adapted. The adaptation is quite simple: add a colon.
|
FWIW I like them. I won't elaborate on why just yet because others might like them too and explain why, or pretty much everyone else thinks it's fine for them to go, and if so, I wouldn't argue against this PR being merged. |
|
Well, if people like them, they should be tested and documented :-) |
|
Notes to self and anyone who wants these to stay:
Notes to everyone:
|
|
My feeling was that it is easier to remember a single rule like "You can
always combine the first one" than it is to remember a list of which ones
do or do not work.
Larry
…On Mon, Oct 23, 2023 at 4:20 PM raiph ***@***.***> wrote:
Notes to self and anyone who wants these to stay:
-
There are tests for each of the combinations if one ignores Q vs q vs
qq, except, I think, qv.
-
They need to be documented.
Notes to everyone:
- If these are to go, does that warrant a deprecation process?
—
Reply to this email directly, view it on GitHub
<#5436 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHSYXUZCXBCDOJA7RQ5YTYA33UDAVCNFSM6AAAAAA6KDMK36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZWGE3TOMZZHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary quotelang markers q, qq, and Q allow for a number of extenders according to the documentation: w, ww, and x. So instead of qw, one could also say q:w, and instead of qqww one could also say qq:ww.
The grammar however ALSO allows for: to, s, a, h, f, c, b, o. Allowing one to say qqto and Qf (to name but two of the possible combinations).
I think this is taking the TIMTOWTDO a little too far. So this commit removes support for these undocumented quotelang extenders.
This breaks three spectest files:
because they check for a, b and to as quotelang extenders respectively. If this change is OKd, then these tests will have to be adapted. The adaptation is quite simple: add a colon.