Prevent a segfault on deref of null typed pointer #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a better Bool coercion for Pointer
zoffixznet
added a commit
that referenced
this pull request
Aug 5, 2018
NQP bump brought: Raku/nqp@2018.06-132-ga53d313...2018.06-134-g7729d0a 7729d0a [MoarVM Bump] Brings 16 commits 20b2eb7 Add pow_i to docs MoarVM bump brought: MoarVM/MoarVM@2018.06-331-g2c74b67...2018.06-347-gca0ece5 ca0ece5 Merge pull request #888 from Kaiepi/configure 7cab426 Merge pull request #920 from jstuder-gh/mv_templates_right_location 700ce36 Merge pull request #921 from jstuder-gh/carray_str_leak 22d710e Merge pull request #928 from MasterDuke17/use_correct_types_in_find_deopt_target_and_index_signature f497f15 Use correct types in find_deopt_target_and_index 05990ef Merge pull request #927 from MasterDuke17/speedup_zero_slots_by_using_memset e1df341 Speedup zero_slots by using memset... 04d1c11 Merge pull request #897 from MasterDuke17/add_pragma_to_switch_to_silence_clang_warning f143836 Merge pull request #896 from MasterDuke17/add_parens_to_expressions_to_silence_clang_warnings 977f3e1 Merge pull request #922 from Kaiepi/makefile 5fccbe2 Add parens to expressions to silence clang warning efea448 Add pragma to switch to silence clang warning ecff5b4 Add missing .h suffix to build/Makefile.in 46c08a0 Fix memory leak in CArray given P6 Strs b66be6e Move exprjit templates to the proper location 3bf120a Fix Configure.pl version detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fail rather than return a type object for null deref
Stops
perl6 -e 'use NativeCall; my $a = Pointer[int32].new; say $a.deref'
Segmentation fault (core dumped)
Also add a better Bool coercion for Pointer
This is a rework of #769