Convert more BOOTSTRAPATTRs to Attributes #902
Conversation
This is a second pass, changing individual instances of BOOTSTRAPATTR to Attributes even if not all for a class could be converted. Additionally, this includes a change to scalar_attr() to permit creating Attributes without setting :auto_viv_container. The change to Code's $!compstuff allows the JVM build to compile; however, the install still fails with 'Flattening named argument must have VMHash REPR'.
|
Not sure about the AppVeyor builds, it passes |
|
Ugh, this is what I get for trying to sync Moar and JVM development and testing late at night. If you just apply the Code.HOW change, you get the JVM behavior like I described. However, the complete PR now gives: /home/dan/Source/perl6/rakudo-j/install/bin/nqp-j --target=jar --output=blib/Perl6/Compiler.jar --encoding=utf8 |
So that we can re-use it in fixing up other I/O.
This solves the same problem IO::Socket::Async had with uncatchable exceptions on decoding errors.
Also allow the encoding to be specified, in preparation for giving Proc::Async and IO::Socket::Async encoding support.
One less check to make in a hot loop.
Part of the Str.match overhaul
They're essentially free nowadays, except from prevening static inlining, which we only really care about for native ops, which don't do method calls.
Which, of note, has a fix to give better errors when trying to invoke a native parameter.
Create a Seq from a given iterator, given the next N elements of the iterator (if available of course).
Skip at least N values of the iterator, and return the result of the next pull-one. Initially I thought about adding this as a method to Rakudo::Internals, but it seemed more logical to add it here. Although this may have adverse effects, as now every class that does Iterator will have a copy of this method?
|
So, what is the state of this PR ?? If I revert e8c8af6 , the JVM builds fine again. Which we would need for a release. |
|
I'm continuing to try and find a solution that isn't just copying back in the old code and having an |
This reverts commit e8c8af6. Reverting per discussion[^1] to unbust JVM build. The work will be rethought and added at a later date. [1] #902 (comment)
|
Reverted in 2d5a2c9d16 |
This is a second pass, changing individual instances of BOOTSTRAPATTR to
Attributes even if not all for a class could be converted. Additionally,
this includes a change to scalar_attr() to permit creating Attributes
without setting :auto_viv_container.
The change to Code's $!compstuff allows the JVM build to compile;
however, the install still fails with 'Flattening named argument must
have VMHash REPR'.
Passes
make specteston Moar.