Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executer, rename sg_parser_unhandled_regex #203

Closed
theludovyc opened this issue Mar 12, 2023 · 7 comments
Closed

Executer, rename sg_parser_unhandled_regex #203

theludovyc opened this issue Mar 12, 2023 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@theludovyc
Copy link
Collaborator

Since Parser was split in two, it is Executer send this signal.

So I think we can rename it in "sg_custom_regex" ?

@theludovyc theludovyc added the enhancement New feature or request label Mar 12, 2023
@Jeremi360
Copy link
Contributor

Jeremi360 commented Mar 12, 2023

Since Parser was split in two, it is Executer send this signal.

So I think we can rename it in "sg_custom_regex" ?

Yes, I think this is a good name and previous name felt me as being too long.
And I think we should name function that adds regex add_custom_regex() then.

@theludovyc
Copy link
Collaborator Author

Also agree for add_custom_regex()

@theludovyc theludovyc added this to the 2.0.1 milestone Mar 12, 2023
@theludovyc
Copy link
Collaborator Author

Maybe add_custom_regex_to_parse(...) is better ?

@Jeremi360
Copy link
Contributor

Maybe add_custom_regex_to_parse(...) is better ?

@theludovyc this is really long name for func, and I don't like it.
And to make this clear we can just comments so it automatically clearly it out in docs.
On the other hand your in proposition is func name self explanatory.

@theludovyc
Copy link
Collaborator Author

theludovyc commented Mar 13, 2023

I am afraid that add_custom_regex() is too ambiguous. But yes with comments it can be good :)

@Jeremi360
Copy link
Contributor

I am afraid that add_custom_regex() is too ambiguous. But yes with comments it can be good :)

I think it would be ambiguous only if we had some other func with similar name or functionality

@theludovyc
Copy link
Collaborator Author

I see what you mean. So let's go for add_custom_regex() :)

Jeremi360 added a commit that referenced this issue Mar 13, 2023
Fix #203 rename unhandled_regex to custom_regex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants