fix ConcurrentModificationException during unsubscription #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NemoOudeis
suggested changes
Apr 10, 2019
| @@ -54,7 +54,7 @@ class Store<State: StateType> ( | |||
| middleware(dispatch, getState)(dispatchFunction) | |||
| }) | |||
|
|
|||
| val subscriptions: MutableList<SubscriptionBox<State, Any>> = mutableListOf() | |||
| val subscriptions: java.util.concurrent.CopyOnWriteArrayList<SubscriptionBox<State, Any>> = CopyOnWriteArrayList() | |||
There was a problem hiding this comment.
you should probably use an import statement instead of the fully qualified name
|
Does the |
|
a note on the commit message: can follow our standard?, i.e. in particular the header line and reference to the issue in the footer Commit MessagesWe write our commit messages according to the following pattern: with
|
…when performing subscription/unsubscription ConcurrentModificationException is thrown whenever the store is attempting to subscribe/unsubscribe any subscriber during dispatching new states. This commit creates unit tests to reproduce this bug.
legolaswang
force-pushed
the
fix-unsubscription
branch
from
1d0ba90
to
e552350
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix java.util.ConcurrentModificationException on the subscriptions object, which may occur when dispatch an action while unsubscribe some StoreSubscribers