This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
REM-24817 Fix swizzle crash when there is no original method #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…swizzle gets added twice - store a NULL NSValue as the original implementation if there wasn't an original method - use a concatenation of the class name and method selector as the map key - swizzle the WKWebView delegate before calling the original method because WebKit appears to save a list of the delegate selectors that the delegate can respond to at the time of the setDelegate: call. Without this change the swizzling won’t work on the initial WebView load - remove mistakenly committed swizzle else clause
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
=========================================
Coverage ? 81.27%
=========================================
Files ? 30
Lines ? 1207
Branches ? 0
=========================================
Hits ? 981
Misses ? 226
Partials ? 0
Continue to review full report at Codecov.
|
donnie-jp
pushed a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Dec 14, 2018
…~SHIVAIAH.MAHESHA/alpha-ios-perftracking:REM-20701 to master * commit '87cdbfeeda486444fd493cdb86896f5c050d93e7': Code Review Comments Code Review comments/Adding more tests [REM-20701][iOS][Perf] Write unit tests for RingBuffer class
donnie-jp
pushed a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Dec 14, 2018
…TH/perftracking_ds:release/1.1-merge-from-gh-20180130 to master * commit 'dcfd3ee904abb3f238e296aea80297d9e5e7f95e': REM-25612 bump podspec for 1.1 release (rakutentech#25) feat(swizzling): REM-25021 Rewrite NSURLSessionTask swizzling (rakutentech#24) [REM-25203] Apply selector-preserving method swizzling to UIControl/UICollectionViewCell/UITableViewCell. [REM-25202] [iOS][Perf] Apply selector-preserving method swizzling to UIViewController. [REM-25200] Apply selector-preserving method swizzling to UIWebView (rakutentech#21) REM-25339 Add RPTForceTrackingEnabled usage description to README (rakutentech#20) REM-25345 Add tests for implementationWithBlock swizzling (rakutentech#19) REM-24817 Fix swizzle crash when there is no original method and the swizzle gets added twice (rakutentech#16) REM-25242 Fix redirect handling in custom protocol (rakutentech#15) REM-25138 Debug builds should always send performance data if config API response is valid (rakutentech#12) feat(swizzling): REM-24817 Rewrite WKWebView swizzling (rakutentech#14) REM-25817 Fix crash that occurs when info.plist keys are missing by failing safely in release builds (rakutentech#13) REM-25128 Prepare for publishing to CocoaPods (rakutentech#10)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified in example app on iOS 11 simulator