This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
REM-25644 Disable NSURLProtocol tracking #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default behaviour is to disable NSURLProtocol tracking because it is experimental/risky - it must be explicitly enabled in the plist by `RPTEnableProtocolWebviewTracking` boolean flag - change tracking manager 'disable' property to an 'enable' property and update affected logic
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 84.45% 84.77% +0.31%
==========================================
Files 24 24
Lines 1274 1274
==========================================
+ Hits 1076 1080 +4
+ Misses 198 194 -4
Continue to review full report at Codecov.
|
vito1188
approved these changes
Jan 31, 2018
| @@ -40,7 +40,7 @@ static void endTrackingWithUIWebView(UIWebView *webView) | |||
|
|
|||
| uint_fast64_t trackingIdentifier = [objc_getAssociatedObject(webView, _RPT_UIWEBVIEW_TRACKINGIDENTIFIER) unsignedLongLongValue]; | |||
|
|
|||
| if (trackingIdentifier && manager.disableProtocolWebviewObserving) | |||
| if (trackingIdentifier) | |||
donnie-jp
added a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Feb 1, 2018
- disable NSURLProtocol tracking by default because it is experimental/risky - it must be explicitly enabled in the plist by `RPTEnableProtocolWebviewTracking` boolean flag - change tracking manager 'disable' property to an 'enable' property and update affected logic
donnie-jp
pushed a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Dec 14, 2018
…TH/perftracking_ds:release/1.1-merge-from-gh-20180201 to master * commit '4c04b6edd167198796935f6d3718d7f865a55da2': REM-25612 Add changelog (rakutentech#28) REM-25612 Add RPTLogVerbose macro and use it instead of RPTLog in non-essential logging (rakutentech#27) REM-25644 Disable NSURLProtocol tracking (rakutentech#26)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPTEnableProtocolWebviewTrackingboolean flag