This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
feat(build): REM-25979 Use shared build config #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnie-jp
force-pushed
the
feature/rem-25979-sharedbuildconfig
branch
from
921606f
to
02a202b
Compare
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 84.91% 84.91%
=======================================
Files 24 24
Lines 1286 1286
=======================================
Hits 1092 1092
Misses 194 194Continue to review full report at Codecov.
|
the-pear
approved these changes
Mar 22, 2018
donnie-jp
pushed a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Dec 14, 2018
…~SHIVAIAH.MAHESHA/alpha-ios-perftracking:REM-21064 to master * commit 'b9a0512d58be39635a11c918e25d3d6510972e5b': Code Review Comments
donnie-jp
pushed a commit
to donnie-jp/ios-perftracking
that referenced
this pull request
Dec 14, 2018
…ITH/perftracking_ds:release/1.2.0-gh-20180611 to master * commit '749df5fae573398c066d1e6d70e7573abc18923b': APTT-268 Update version and changelog for 1.2.0 release (rakutentech#46) [APTT-430] Do not collect/send measurements that don't have an associated metric when config API response flag enableNonMetricMeasurement is false (rakutentech#45) Fix tracking of UIWebView requests and response status codes (rakutentech#43) Fixed warnings in project code. (rakutentech#42) [APTT-260] Disable swizzling in setDelegate swizzle of UIWebView/WKWebView if tracking is not enabled (rakutentech#37) fix code review issues. Use xcodeproj 1.5.7 [APTT-27] WKWebView / UIWebView - Send HTTP/S network request status information to backend. [APTT-27] WKWebView / UIWebView - Send HTTP/S network request status information to backend. (rakutentech#39) Fixed os and device model params in configuration request. (rakutentech#40) Added device info and OS version to config request (rakutentech#38) APTT-15 Disabled measurements collection when no active metric exists (rakutentech#36) APTT-67 Swizzle on the furthest ancestor (rakutentech#35) feat(build): REM-25979 Use shared build config (rakutentech#34) fix(metric): REM-25743 use timeIntervalSince1970 for start/end time of device metric so we are consistent with other time intervals in codebase (rakutentech#33) remove code duplication REM-25613 Send HTTP/S network request status information to backend. REM-25661 Add unit test for empty URL REM-25661 Don't track a measurement with an empty url.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.