Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Aptt260 fake #44

Closed
wants to merge 5 commits into from
Closed

Aptt260 fake #44

wants to merge 5 commits into from

Conversation

vito1188
Copy link
Contributor

Don't merge it

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@8635c08). Click here to learn what that means.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #44   +/-   ##
=========================================
  Coverage          ?   88.66%           
=========================================
  Files             ?       25           
  Lines             ?     1288           
  Branches          ?        0           
=========================================
  Hits              ?     1142           
  Misses            ?      146           
  Partials          ?        0
Impacted Files Coverage Δ
RPerformanceTracking/Private/_RPTTracker.m 93.75% <0%> (ø)
RPerformanceTracking/Private/_RPTSender.m 85.45% <100%> (ø)
...eTracking/Private/_RPTClassManipulator+WKWebView.m 76.47% <54.54%> (ø)
...eTracking/Private/_RPTClassManipulator+UIWebView.m 92.13% <78.57%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8635c08...500e78b. Read the comment docs.

else
{
decisionHandler(WKNavigationResponsePolicyAllow);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this should crash if the swizzle gets called.
It'd be nice if the branch was rebased on master so only this diff is shown.

@donnie-jp donnie-jp closed this May 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants