Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

build: output coverage report using xcov-danger #14

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

donnie-jp
Copy link
Contributor

@donnie-jp donnie-jp commented Sep 4, 2019

Description

  • output coverage report using xcov-danger
  • use Gemfile for dependencies
  • only call the fastlane coverage lane when running locally because on travis Danger will be run as a separate script command after fastlane
  • add vendor dir to excluded lint files because travis adds all its bundler dependencies to a vendor dir within the repo root

Links

SDKCF-1159

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I ran fastlane ci without errors

@rakutentech-danger-bot
Copy link
Collaborator

rakutentech-danger-bot commented Sep 5, 2019

Current coverage for RRemoteConfig.framework is 90.67%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

- use Gemfile for dependencies
- only call the fastlane coverage lane when running locally because on travis Danger will be run as a separate script command after fastlane
- add vendor dir to excluded lint files because travis adds all its bundler dependencies to a vendor dir within the repo root
@donnie-jp donnie-jp changed the title feat: setup coveralls to only upload reports when run on CI build: output coverage report using xcov-danger Sep 5, 2019
Copy link

@corycaywood corycaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@donnie-jp donnie-jp merged commit 86b6363 into rakutentech:master Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants