Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow comments on the rules method of the Request class #314

Merged

Conversation

Ken-vdE
Copy link
Contributor

@Ken-vdE Ken-vdE commented Jan 4, 2024

I've expanded the functionality to allow comments and hidden params to also be defined within the PHPDocs of the rules method in the Request classes.

@lrd comments defined on the controller methods are appended below the @lrd comments defined on the Request method.

@LRDparam defined on the Request method are combined with @LRDparam defined on the controller methods. However, when a param with the same name is defined on both, the controllers definition will take precedence.

P.s. There is an error in your readme.
An example is given to determine response codes:
@LRDparam responses 200,422
However, that should be @LRDresponses 201|244

@kevincobain2000 kevincobain2000 requested review from kitloong and kevincobain2000 and removed request for kitloong January 4, 2024 20:30
@kevincobain2000 kevincobain2000 merged commit 6cea81c into rakutentech:master Jan 4, 2024
@kevincobain2000
Copy link
Member

P.s. There is an error in your readme.
An example is given to determine response codes:
@LRDparam responses 200,422
However, that should be @LRDresponses 201|244

Thanks
#316

@Ken-vdE Ken-vdE mentioned this pull request Jan 5, 2024
@Ken-vdE
Copy link
Contributor Author

Ken-vdE commented Jan 5, 2024

Readme expanded in #318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants