Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix facade accessor #333

Merged

Conversation

giraz82
Copy link
Contributor

@giraz82 giraz82 commented Feb 7, 2024

Problem
Psalm inspection reports exception on projects that has laravel-request-doc as dependency

To Reproduce
Steps to reproduce the behavior:

  1. composer create-project laravel/laravel:^10.0 laravel
  2. cd laravel-request-docs-test
  3. composer require rakutentech/laravel-request-docs
  4. composer require --dev vimeo/psalm -W
  5. composer require --dev psalm/plugin-laravel -W
  6. Add a psalm.xml config file with following content:
<?xml version="1.0"?>
<psalm
    findUnusedCode="true"
    findUnusedBaselineEntry="true"
>
    <projectFiles>
        <directory name="src" />
    </projectFiles>
</psalm>
  1. ./vendor/bin/psalm-plugin enable psalm/plugin-laravel
  2. ./vendor/bin/psalm
  3. See in the output:
Exception: Target class [laravel-request-docs] does not exist.
Skipping \Rakutentech\LaravelRequestDocs\LaravelRequestDocsFacade.

Expected behavior
Not to see this error.

Versions:

  • Laravel Version: 10.43
  • PHP Version: 8.3.1
  • Laravel Request Docs Version: 2.29

@kevincobain2000
Copy link
Member

Will merge it soon.
thanks!!

@kevincobain2000 kevincobain2000 merged commit 24ea575 into rakutentech:master Feb 9, 2024
@kevincobain2000
Copy link
Member

v2.30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants