Lucene search UI changes #1401
Merged
Lucene search UI changes #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # yarn.lock
# Conflicts: # packages/datagateway-search/server/e2e-test-server.js # packages/datagateway-search/src/card/datasetSearchCardView.component.test.tsx # packages/datagateway-search/src/card/datasetSearchCardView.component.tsx # packages/datagateway-search/src/card/investigationSearchCardView.component.tsx # packages/datagateway-search/src/searchPageContainer.component.tsx # packages/datagateway-search/src/searchTabs.component.tsx # packages/datagateway-search/src/table/datafileSearchTable.component.tsx # packages/datagateway-search/src/table/datasetSearchTable.component.tsx # packages/datagateway-search/src/table/investigationSearchTable.component.tsx
- Add tooltip to checkbox to explain what it does - It will no longer trigger the search whenever it changes
1 task
|
The checks are failing for the E2E tests because the test servers don't support the new Lucene search endpoint yet. |
|
Not entirely sure where this is going wrong right now but the datafile search table is not stretching to fill the width of its container, unlike the other search tables
|
|
That is weird, I never had this problem before! I'll have a look. |
|
Note for the above: this was in Firefox. Let me know if things are different for you in other browsers, etc |
When the filter panel is hidden, datafile search table now uses the full width of the parent container
Made it more efficient by bundling it all together in the current tab change
…truments @ dataset/dataset level
Also, fix lucene search pagination & issues with axios v1 upgrade (switching to use URLSearchParams)
louise-davies
force-pushed
the
feature/free-text-search-#1152
branch
from
0ed2ff7
to
9e8621c
Compare
if you had multiple entity types available for search, card view pagination could fail if they had different amounts of results Since the "hidden" tab would reset the page to 1 when it detected the page was greater than it's max page
- Also removed lingering enzyme stuff - And refactored SearchPageComponent to use redux hooks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1401 +/- ##
===========================================
- Coverage 96.25% 95.35% -0.91%
===========================================
Files 170 182 +12
Lines 7326 7843 +517
Branches 2347 2506 +159
===========================================
+ Hits 7052 7479 +427
- Misses 254 329 +75
- Partials 20 35 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
also some other minor styling stuff
- don't know what changed to cause this, likely backend changes
louise-davies
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes support for new Lucene search & new UI to support the Lucene search change.
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Demo
DataGateway.Search.and.8.more.pages.-.Work.-.Microsoft.Edge.2022-12-14.15-42-46_Trim.2.mp4
Agile board tracking
Closes #1363, #1362