Feature/use isis data publications #1464

[jounaidr]

Description

This PR migrates Study landing/table/card views to use new ICAT 5 DataPublication endpoints. The new page hierarchy can be viewed using /browseDataPublications/instrument, and navigating through to see the new landing/table/card views. Note that for the linked investigation, the parent DOI was removed as it seemed to now be always a duplicate.

To finish PR

Currently all the features are implemented, however some e2e tests are failing. These are mostly to do with investigation doi links, as to fix another test and for consistency the doi's were taken from the investigations datacollection property rather than the previous studyInvestigations. An attempt at fixing this can seen here, however i'm unsure if this will actually work.

Testing instructions

Check that each dataPublication page in the hierarchy loads as expected.

Agile board tracking

closes #1464

[codecov]

Codecov Report

Patch coverage: 96.19% and project coverage change: -0.07 ⚠️

Comparison is base (4c375c0) 96.33% compared to head (c4e9632) 96.26%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1514      +/-   ##
===========================================
- Coverage    96.33%   96.26%   -0.07%     
===========================================
  Files          161      161              
  Lines         6934     6860      -74     
  Branches      2146     2126      -20     
===========================================
- Hits          6680     6604      -76     
- Misses         233      236       +3     
+ Partials        21       20       -1     

Flag	Coverage Δ
common	95.53% <92.85%> (-0.10%)	⬇️
dataview	96.85% <96.79%> (-0.12%)	⬇️
download	96.73% <ø> (ø)
search	96.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/datagateway-common/src/api/index.tsx	96.68% <ø> (ø)
...ages/datagateway-common/src/api/investigations.tsx	100.00% <ø> (ø)
packages/datagateway-common/src/app.types.tsx	100.00% <ø> (ø)
...n/src/table/cellRenderers/cellContentRenderers.tsx	92.30% <ø> (-1.25%)	⬇️
...dataview/src/views/citationFormatter.component.tsx	98.27% <ø> (ø)
.../datagateway-dataview/src/page/idCheckFunctions.ts	92.20% <66.66%> (ø)
...anels/isis/investigationDetailsPanel.component.tsx	97.46% <71.42%> (-2.54%)	⬇️
...card/isis/isisInvestigationsCardView.component.tsx	95.38% <77.77%> (-3.06%)	⬇️
...table/isis/isisDataPublicationsTable.component.tsx	92.59% <92.59%> (ø)
...es/datagateway-common/src/api/dataPublications.tsx	100.00% <100.00%> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[joshuadkitenge]

LGTM