Homepage / login options for DLS #1049
Assignees
Labels
Comments
agbeltran
added
enhancement
1 task
|
Transferring as this is primarily a SciGateway issue |
sam-glendenning
pushed a commit
that referenced
this issue
Apr 28, 2022
…n not logged in #1049 The user's login state now has no effect on access to the homepage or display of the navigation drawer. This means that DLS now allows access to the homepage at the web root and the navigation drawer shows all web app routes (access to these is determined elsewhere). This is in comparison to how things used to work on DLS, whereby all nav drawer routes including the homepage were inaccessible until the user logged in.
sam-glendenning
pushed a commit
that referenced
this issue
Apr 28, 2022
sam-glendenning
pushed a commit
that referenced
this issue
Apr 28, 2022
Since this PR is related to SciGateway login changes, I thought I'd lump in this additional fix. This addresses the problem whereby the user would try to navigate to a protected resource, be redirected to login, login successfully and then be mistakenly directed to the homepage instead of their original page. This was previously working by storing the referrer in the login redirect state but this state is cleared on a page refresh, meaning we defaulted back to the homepage. We now store the referrer in localStorage and clear it when we don't need it.
3 tasks
sam-glendenning
pushed a commit
that referenced
this issue
Apr 29, 2022
sam-glendenning
pushed a commit
that referenced
this issue
Apr 29, 2022
sam-glendenning
pushed a commit
that referenced
this issue
May 5, 2022
The reason the referrer was being wiped from state was because the user was logging in, which meant the login page becomes inaccessible and is thus replaced with logout. This removes the referrer from state. I am now changing this so we grab the referrer earlier in the process before redirecting. This removes the need to use localStorage
sam-glendenning
pushed a commit
that referenced
this issue
May 5, 2022
…default-#1049 Homepage accessible regardless of login status #1049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description:
Currently, we have a login page as the homepage for DLS (as it was in Topcat). I think it would be better to show the homepage and provide the login page when the user picks any of the menu items (rather than only for 'My Data' as it is for ISIS).
Acceptance criteria:
The text was updated successfully, but these errors were encountered: