Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1081 - add autoLogin setting to control whether we attempt autoLogin #1084

Merged
merged 4 commits into from
Jun 9, 2022

Conversation

louise-davies
Copy link
Member

Description

See title.

Also removed the authUrl argument from verifyUsernameAndPassword because it doesn't change so we can just reuse the old value

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage
  • No autologin error appears when using DLS authenticator and autoLogin: false

Agile board tracking

Closes #1081

- also simplify some code by removing authUrl (as this never changes)
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #1084 (da1024d) into develop (6223ec1) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1084      +/-   ##
===========================================
- Coverage    97.95%   97.95%   -0.01%     
===========================================
  Files           42       42              
  Lines         1566     1565       -1     
  Branches       419      420       +1     
===========================================
- Hits          1534     1533       -1     
  Misses          31       31              
  Partials         1        1              
Impacted Files Coverage Δ
src/state/reducers/scigateway.reducer.tsx 100.00% <ø> (ø)
src/state/scigateway.types.tsx 100.00% <ø> (ø)
src/authentication/icatAuthProvider.tsx 100.00% <100.00%> (ø)
src/loginPage/loginPage.component.tsx 98.51% <100.00%> (-0.02%) ⬇️
src/state/actions/scigateway.actions.tsx 98.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6223ec1...da1024d. Read the comment docs.

@louise-davies louise-davies marked this pull request as ready for review June 9, 2022 13:01
Copy link
Contributor

@sam-glendenning sam-glendenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made a small commit to clarify some meaning in tests - apart from that I'm happy (assuming the tests pass)

@louise-davies louise-davies merged commit 9d5c7a5 into develop Jun 9, 2022
@louise-davies louise-davies deleted the bugfix/no-autologin-errors-dls-#1081 branch June 9, 2022 15:28
@louise-davies louise-davies added the bug Something isn't working label Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message appears to do with autologin when there's no anon authenticator
2 participants