Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: patch git deps in root Cargo.toml #56

Merged

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Sep 15, 2022

patch git deps in ./Cargo.toml instead of using rev everywhere, this makes it easier to update the pinned commit for the entire repo.

note: due to how patching git deps works in cargo itself, the URL must be different. A known hack is to use double slashes // to trick cargo both are different

Cargo.toml Outdated
ethereum-consensus = { git = "https://github.com/ralexstokes//ethereum-consensus", rev = "a8110af76d97bf2bf27fb987a671808fcbdf1834" }

[patch."https://github.com/ralexstokes/ssz-rs"]
ssz-rs = { git = "https://github.com/ralexstokes//ssz-rs", rev = "cb08f18ca919cc1b685b861d0fa9e2daabe89737" }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do also want to pin beacon-api-client as this was the issue that launched this whole arc

Cargo.toml Outdated Show resolved Hide resolved
mattsse and others added 2 commits September 17, 2022 15:16
Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
@mattsse
Copy link
Contributor Author

mattsse commented Sep 17, 2022

done

Copy link
Owner

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank you!

@ralexstokes ralexstokes merged commit 117815c into ralexstokes:main Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants