Fixed decoder needing flush in some cases #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
Ah, I forgot to mention. In your own interest, could you also submit a follow-up PR containing a test case and a minimal .h264 file triggering the issue? It's not strictly necessary, but otherwise there is a risk for that logic to accidentally get refactored out at some point. |
|
@ralfbiedert thanks for merging. I was unsure of a test on this. The file decodes without any error without this code. Only that output has artifacts and that too on subsequent call to decode. Unclear if I should add something that compares output to an image |
|
For now added a simple test to validate fame is decoded properly #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a local test environment i have an h264 stream that returns 0 on the first call to decode_frame_no_delay and iBufferStatus != 0.
In this case we should check the numbers of frames remaining in buffer (0 or 1) and flush the buffer if it is 1.