Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard build metadata #32

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flying-sheep
Copy link
Contributor

Projects should contain PEP 517 metadata.

If you want, you can move the metadata in setup.py into that file too, but no matter what, it needs to be there.

@ralhei
Copy link
Owner

ralhei commented Jul 27, 2023

Thanks for your engagement. But would you mind to provide a bit more background for this toml file and its entries - which problem does it solve for me (or you) that I'm currently not aware of? How would I reproduce it?

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Jul 27, 2023

It’s how you write a python package.

Almost all tools still have legacy fall-back code that just uses setup.py, but that’ll go away eventually.

Directly invoking python setup.py <command> is also deprecated, setuptools should tell you about that. I replaced that too. (python -m build is the standard-based tool to build sdists and wheels)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants