Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Rotation bug #34

Closed
iLLiac4 opened this issue Jul 27, 2017 · 7 comments
Closed

Auto Rotation bug #34

iLLiac4 opened this issue Jul 27, 2017 · 7 comments

Comments

@iLLiac4
Copy link

iLLiac4 commented Jul 27, 2017

Hi. I have tested this feature and it works great if you are right handed. If you are left handed it rotates it to right handed too quickly.
You can try it and will see that if you solder with left hand it too quickly turns to right hand.

I hope you understand what i mean :)

@Ralim
Copy link
Owner

Ralim commented Jul 27, 2017

Hi,
I understand what you mean, I am guessing you hold your iron with the screen pointing further up than I normally do. I will push a bug fix version shortly that should increase the threshold required. :)

@iLLiac4
Copy link
Author

iLLiac4 commented Jul 27, 2017

Yes i am holding it as pencil since i am left heanded.

@Ralim
Copy link
Owner

Ralim commented Jul 27, 2017

Original there was only a minimal threshold, so when the screen rolled past flat the screen would flip to the other orientation. I am bumping up the threshold so that it will not rotate until the screen rolls further past flat. Just testing the build on my units and then I'll push up a patch.

Ralim added a commit that referenced this issue Jul 27, 2017
@Ralim
Copy link
Owner

Ralim commented Jul 27, 2017

@iLLiac4 Can you try the latest v1.16.1?

@iLLiac4
Copy link
Author

iLLiac4 commented Jul 27, 2017

Much better. Probably this is hard to do but when you pick them up from the table and if it flips to right hand display you have to make it almost vertical to flip it to left menu.
But as i said this is probably hard to achive.

@Ralim
Copy link
Owner

Ralim commented Jul 28, 2017

Hi,
I'm not quite sure what you mean by this :(
Which axis are you rotating around?

I will be polishing this a bit more in the coming days, as I think I have found an edge case I need to test soon.

@Ralim
Copy link
Owner

Ralim commented Jul 31, 2017

I'm going to close this for now, please open this again if the issue is not resolved.

@Ralim Ralim closed this as completed Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants