Migrate latest rally-versioning changes from 1.9.0 to open-source #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
commented
Mar 9, 2020
src/main/scala/com/rallyhealth/sbt/versioning/GitVersioningPlugin.scala
Outdated
Show resolved
Hide resolved
jeffmay
commented
Mar 9, 2020
src/sbt-test-disabled/semver/rename-artifact/project/plugins.sbt
Outdated
Show resolved
Hide resolved
jeffmay
force-pushed
the
migrate-1.9.0
branch
4 times, most recently
from
b6b2015
to
8148680
Compare
jeffmay
commented
Mar 9, 2020
jeffmay
commented
Mar 9, 2020
jeffmay
commented
Mar 10, 2020
src/test/scala/com/rallyhealth/sbt/versioning/SemanticVersionSpec.scala
Outdated
Show resolved
Hide resolved
jeffmay
commented
Mar 10, 2020
jeffmay
commented
Mar 10, 2020
arkban
approved these changes
Mar 10, 2020
jscrally
approved these changes
Mar 11, 2020
jeffmay
commented
Mar 11, 2020
| @@ -135,7 +143,7 @@ object GitVersioningPlugin extends AutoPlugin { | |||
| autoFetchTimeout := 15, // seconds | |||
|
|
|||
| autoFetchResult := { | |||
| implicit val logger: Logger = ConsoleLogger() | |||
| implicit val logger: Logger = sLog.value | |||
There was a problem hiding this comment.
This is different from 1.9.0, but I think it makes more sense to inject the logger based on settings, rather than construct it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the latest changes from v1.9.0 of rally-versioning over to the open-source repo.
This will hopefully resolve some of the issues raised on GitHub.