Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let configure detect OPENMP_FCFLAGS #115

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jfowkes
Copy link
Contributor

@jfowkes jfowkes commented Jun 13, 2023

Resolves #114

Correctly detect OpenMP Fortran compiler flags as opposed to assuming they are the same as the C++ compiler (which breaks when matching compilers are not used, e.g. nagfor and gcc/g++). For details see autoconf AC_OPENMP docs:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/html_node/Generic-Compiler-Characteristics.html

Also remove the obsolete AC_PROG_CC_C99 macro:
https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/html_node/Obsolete-Macros.html#index-AC_005fPROG_005fCC_005fC99-1

@jfowkes jfowkes linked an issue Jun 13, 2023 that may be closed by this pull request
@jfowkes jfowkes force-pushed the 114-issue-when-we-link-with-openmp branch from b10ca8b to 85aa120 Compare June 13, 2023 10:54
@jfowkes jfowkes self-assigned this Jun 13, 2023
@jfowkes jfowkes requested a review from tyronerees June 13, 2023 10:59
Copy link
Member

@tyronerees tyronerees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@tyronerees tyronerees merged commit b1b7397 into master Jun 14, 2023
4 checks passed
@tyronerees tyronerees deleted the 114-issue-when-we-link-with-openmp branch June 14, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue when we link with OpenMP
2 participants