Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NowPlaying settings updated very often (e.g. every minute) despite no changes #18

Closed
stripwax opened this issue Oct 16, 2023 · 0 comments

Comments

@stripwax
Copy link

stripwax commented Oct 16, 2023

This storeSettings unfortunately gets triggered a lot, even when there are no changes to settings (noticed on modified time on userpath/settings/NowPlaying.lua and confirmed via logging) Perhaps the following would be better

                if settings.selectedStyle ~= self.selectedStyle then
                       settings.selectedStyle = self.selectedStyle
                       self:storeSettings()
                end

ref: https://www.jogglerwiki.com/forum/viewtopic.php?p=33593#p33593

The exact cause of the multiple regular calls to GetNPStyles() seems to be due to the call to self::showNowPlaying() in function openScreensaver() (or at least that's what I observed via logging the callstack around line 227). So maybe my suggestion only addresses the symptom, and the real fix would be elsewhere

ralph-irving added a commit that referenced this issue Dec 22, 2023
kerneljake pushed a commit to kerneljake/squeezeplaya that referenced this issue Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants