Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add armoured infantry #21

Open
wants to merge 1 commit into
base: APP6-D
Choose a base branch
from
Open

add armoured infantry #21

wants to merge 1 commit into from

Conversation

ycphs
Copy link

@ycphs ycphs commented Mar 24, 2023

add armoured infantry

add armoured infantry
@ralphieraccoon
Copy link
Owner

ralphieraccoon commented Mar 24, 2023

Hi, thanks for the PR! Can you please confirm if this is from APP-6(C) or APP-6(D)? I can't find it in APP-6(C) but I might have just missed it. I've been meaning in incorporate the new revision into the package for some time, but I'm thinking about if it would be best to split the changes off into a different file and let users pick the revision with a package option.

@ralphieraccoon ralphieraccoon self-assigned this Mar 24, 2023
@ycphs
Copy link
Author

ycphs commented Mar 24, 2023

It is displayed APP-6D

Thats the description:

ARMOURED/MECHANIZED/
TRACKED
Type: Entity Subtype
Entity/Entity Type:
MOVEMENT AND
MANOEUVRE/INFANTRY
Symbol Set Code: 10
Code: 121102
Icon Type: Main

@ralphieraccoon
Copy link
Owner

ralphieraccoon commented Mar 24, 2023

Thanks! As it's in revision D I'll hold off on any merge for now until I work out how I'm going to integrate both versions into the package. If you're willing to help create more symbols from revision D in the meantime, feel free to add them to the PR (and change the title accordingly) it would be a great help, then I can work on sorting out the structure of the package on the back end.

@ycphs
Copy link
Author

ycphs commented Apr 14, 2023

It is already stated in APP-6C

Icons in the main sector (figure 3-6) normally reflect the main function of the
symbol, but in some cases can also reflect modifying information (e.g., armoured
engineers). Table 3-3 below shows the icons for use in land unit symbols in the main
sector of the A field of the symbol. In most cases, the dimensions of the icon will be
sized to occupy as much area in the main sector as is available. However, in some
cases the icon may be reduced to allow more room for modifiers for better recognition
or to allow for one icon to modify another (e.g., armoured/self-propelled artillery).

So armoured infantry should be allowed as well as armoured engineers.

@ralphieraccoon
Copy link
Owner

ralphieraccoon commented Apr 14, 2023

I think this is best implemented with a custom icon/modifier for APP-6C since there would be a lot of unique combinations (see the manual for instructions). But as it seems to be specifically defined in APP-6D so I will add it in there. I'm generally going for if the icon is not in a table in the documentation, it's not added as a value in the package.

@ralphieraccoon ralphieraccoon changed the base branch from master to APP6-D April 19, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants