Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected support for NRF52, NodeRED3.1, and unregistered Platforms. #41

Closed
wants to merge 18 commits into from

Conversation

NW-Lab
Copy link
Contributor

@NW-Lab NW-Lab commented Sep 14, 2023

Hello,

This PR proposes four fixes:

  • Allows you to try it even on undefined platforms.
  • Supports NRF52
  • It also works with NodeRED 3.1.
  • When using Japanese, the characters are garbled on the console, so if it is Japanese, switch the console to English mode.

Thank you,

@ralphwetzel
Copy link
Owner

Thank you for this contribution. I can follow most of your proposals - yet had a few comments.
Feedback welcome!

@NW-Lab
Copy link
Contributor Author

NW-Lab commented Sep 23, 2023

thank you for your reply. This repository is very important for using Node-RED MCU.
Even if a new device was registered in Moddable, it was not updated.
I would like to help as much as possible, so please leave a comment.
Thank you.

@ralphwetzel
Copy link
Owner

I would like to help as much as possible, so please leave a comment.

Your contribution is highly appreciated.
If you adapt the two topics according to my comments (given above), I'd be happy to merge your PR & release a new version shortly after - that has support for all known platforms.

@NW-Lab NW-Lab closed this by deleting the head repository Sep 26, 2023
@NW-Lab
Copy link
Contributor Author

NW-Lab commented Sep 26, 2023

I split it up and made a pull request.
Thank you.

#42
#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants