Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of icons, support for bootstrap #6

Merged
merged 1 commit into from Sep 7, 2019

Conversation

tekstrand
Copy link
Contributor

#2

Also adds support for bootstrap theme using bootstrap icons

@ramack
Copy link
Owner

ramack commented Sep 7, 2019

Thanks for your efforts

@ramack ramack merged commit 3a3f169 into ramack:master Sep 7, 2019
@ramack
Copy link
Owner

ramack commented Sep 8, 2019

Today I tried it with the bootstrap-darkroom theme and the rotate icons are not shown... Which versions (piwigo and theme) did you use for testing? and which theme exactly did you use?

@tekstrand
Copy link
Contributor Author

I used the most recent version of bootstrap-darkroom. When you say that they didn't show, do you mean they icons failed to load(empty squares would show instead) or that no icons showed up at all?

@ramack
Copy link
Owner

ramack commented Sep 8, 2019

In "Bootstrap" I see a box and a space...
In "Bootstrap Darkroom" I do not even see empty squares...

@tekstrand
Copy link
Contributor Author

It's theoretically possible that the version you're using does not have those fontawesome icons, do you know which version of the themes you have?

@ramack
Copy link
Owner

ramack commented Sep 9, 2019

tss.. this sounds more easy than it is. - I am too dumb to find where piwigo is showing it's own version. In the code I see:
Theme Name: Bootstrap Default
Version: 1.0.7

Theme Name: Bootstrap Darkroom
Version: 2.4.1

'PHPWG_VERSION', '2.9.5'

And obviously the modus theme I installed to step into #1 is using font based icons... Not sure whether this is what is understood as fontawesome icons though.

@tekstrand
Copy link
Contributor Author

I have those versions as well. I was able to replicate the issue on bootstrap default. We could switch back to the previous icons, it doesn't look like bootstrap-default support font awesome, only the old glyphicons(https://getbootstrap.com/docs/3.3/components/) which doesn't have any good options for what we want. Preference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants