Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary test code #106

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Remove unnecessary test code #106

merged 1 commit into from
Mar 24, 2024

Conversation

raman325
Copy link
Owner

Proposed change

Removing unnecessary files and code in the zwave_js tests. I can simplify things by mocking the node and client.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@github-actions github-actions bot added code-quality Pull requests that improve code quality python Pull requests that update Python code labels Mar 24, 2024
Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (e20935b) to head (10904a5).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files          19       19           
  Lines        1209     1209           
=======================================
  Hits         1086     1086           
  Misses        123      123           

@raman325 raman325 merged commit 086e888 into main Mar 24, 2024
9 checks passed
@raman325 raman325 deleted the zwave branch March 24, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Pull requests that improve code quality python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant