Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry syncing lock after failure #123

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Retry syncing lock after failure #123

merged 4 commits into from
Apr 2, 2024

Conversation

raman325
Copy link
Owner

@raman325 raman325 commented Apr 1, 2024

Proposed change

To prevent lock from permanently being out of sync, we poll once a minute and update the lock again if needed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

@github-actions github-actions bot added enhancement New feature or request python Pull requests that update Python code labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 89.56%. Comparing base (87d8ecf) to head (a9c26f7).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   89.90%   89.56%   -0.35%     
==========================================
  Files          19       19              
  Lines        1209     1207       -2     
==========================================
- Hits         1087     1081       -6     
- Misses        122      126       +4     
Files Coverage Δ
custom_components/lock_code_manager/entity.py 97.22% <100.00%> (-0.10%) ⬇️
custom_components/lock_code_manager/event.py 100.00% <ø> (ø)
custom_components/lock_code_manager/sensor.py 100.00% <ø> (ø)
...stom_components/lock_code_manager/binary_sensor.py 93.79% <66.66%> (-2.64%) ⬇️

@github-actions github-actions bot added the javascript Pull requests that update javascript code label Apr 1, 2024
@raman325 raman325 merged commit 30cd01f into main Apr 2, 2024
8 of 10 checks passed
@raman325 raman325 deleted the retry branch April 2, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request javascript Pull requests that update javascript code python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Retry setting or clearing a usercode when it fails
1 participant