Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more update scenarios #66

Merged
merged 7 commits into from
Mar 5, 2024
Merged

Handle more update scenarios #66

merged 7 commits into from
Mar 5, 2024

Conversation

raman325
Copy link
Owner

@raman325 raman325 commented Mar 5, 2024

Proposed change

Handles updates like changing the PIN or calendar entity ID associated with a slot

fixes #63
fixes #59

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

@raman325 raman325 added the bug Something isn't working label Mar 5, 2024
@github-actions github-actions bot added the python Pull requests that update Python code label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.50%. Comparing base (aa8504e) to head (680facf).
Report is 1 commits behind head on main.

❗ Current head 680facf differs from pull request most recent head c6e9ad1. Consider uploading reports for the commit c6e9ad1 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
+ Coverage   89.25%   89.50%   +0.24%     
==========================================
  Files          19       19              
  Lines        1182     1191       +9     
==========================================
+ Hits         1055     1066      +11     
+ Misses        127      125       -2     
Files Coverage Δ
custom_components/lock_code_manager/__init__.py 93.90% <ø> (ø)
...stom_components/lock_code_manager/binary_sensor.py 96.80% <100.00%> (+2.63%) ⬆️
custom_components/lock_code_manager/entity.py 95.97% <ø> (-0.03%) ⬇️
custom_components/lock_code_manager/exceptions.py 92.30% <87.50%> (-7.70%) ⬇️

@raman325 raman325 added bug Something isn't working python Pull requests that update Python code and removed bug Something isn't working python Pull requests that update Python code labels Mar 5, 2024
@raman325 raman325 merged commit 5bd5bdf into main Mar 5, 2024
7 checks passed
@raman325 raman325 deleted the update branch March 5, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code
Projects
None yet
1 participant