Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some error for ingress secret , And other typos. #2

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Fix some error for ingress secret , And other typos. #2

merged 1 commit into from
Nov 12, 2023

Conversation

yanggangtony
Copy link
Contributor

@yanggangtony yanggangtony commented Nov 11, 2023

openssl req -nodes -new -x509 -keyout tls-ingress.key -out tls-ingress.crt -subj "/CN=learnwithgvr.com -days 365

The command provide is wrong to execute , right is

-subj "/CN=learnwithgvr.com"

and also it is not necessary need .

Fix it , and make secret for ingress is more readable.

Signed-off-by: yanggang <gang.yang@daocloud.io>
@yanggangtony yanggangtony changed the title Fix some error for ingress secret. Fix some error for ingress secret , And other typos. Nov 11, 2023
@ramanagali ramanagali merged commit e6dfd54 into ramanagali:main Nov 12, 2023
@yanggangtony yanggangtony deleted the fix-CKS_Preparation_Guide branch November 12, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants