Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-tag-name): npm5 has issues with git tags with @ and / chars #1

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

ramasilveyra
Copy link
Owner

@ramasilveyra ramasilveyra commented Jun 27, 2017

npm5 has issues with git tags with @ and / chars.

NOTE: this doesn't happen with npm 3

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #1 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   54.76%   54.76%           
=======================================
  Files          17       17           
  Lines         126      126           
  Branches       16       16           
=======================================
  Hits           69       69           
  Misses         55       55           
  Partials        2        2
Impacted Files Coverage Δ
src/tasks/Publish/normalise-package-name.js 100% <ø> (ø) ⬆️
src/tasks/Publish/get-git-tag-name.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7408a80...8fbf6d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants