Skip to content

Commit

Permalink
Fix for failing builds (#3206)
Browse files Browse the repository at this point in the history
* build: fix linting errors

* test: remove u180E from test string as it was no longer considered as whitespace

* build: run ci pipeline on pull request too
  • Loading branch information
customcommander committed Dec 17, 2021
1 parent d5e178d commit 1843493
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Build

on: [push]
on: [push, pull_request]

jobs:
coverage:
Expand Down
1 change: 0 additions & 1 deletion source/internal/_xuniqWith.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import _Set from './_Set.js';
import _curry2 from './_curry2.js';
import _includesWith from './_includesWith.js';
import _xfBase from './_xfBase.js';
Expand Down
6 changes: 3 additions & 3 deletions source/is.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import _curry2 from './internal/_curry2.js';

/**
* See if an object (i.e. `val`) is an instance of the supplied constructor. This
* function will check up the inheritance chain, if any.
* function will check up the inheritance chain, if any.
* If `val` was created using `Object.create`, `R.is(Object, val) === true`.
*
* @func
Expand All @@ -26,9 +26,9 @@ import _curry2 from './internal/_curry2.js';
* R.is(Number, {}); //=> false
*/
var is = _curry2(function is(Ctor, val) {
return val instanceof Ctor ||
return val instanceof Ctor ||
val != null && (
val.constructor === Ctor ||
val.constructor === Ctor ||
(Ctor.name === 'Object' && typeof val === 'object'));
});
export default is;
2 changes: 1 addition & 1 deletion test/trim.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ var eq = require('./shared/eq');


describe('trim', function() {
var test = '\x09\x0A\x0B\x0C\x0D\x20\xA0\u1680\u180E\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028\u2029\uFEFFHello, World!\x09\x0A\x0B\x0C\x0D\x20\xA0\u1680\u180E\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028\u2029\uFEFF';
var test = '\x09\x0A\x0B\x0C\x0D\x20\xA0\u1680\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028\u2029\uFEFFHello, World!\x09\x0A\x0B\x0C\x0D\x20\xA0\u1680\u2000\u2001\u2002\u2003\u2004\u2005\u2006\u2007\u2008\u2009\u200A\u202F\u205F\u3000\u2028\u2029\uFEFF';

it('trims a string', function() {
eq(R.trim(' xyz '), 'xyz');
Expand Down

0 comments on commit 1843493

Please sign in to comment.