Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Can we have an operator similar to https://lodash.com/docs/4.17.11#at #2740

Closed
minaseem opened this issue Dec 10, 2018 · 4 comments
Closed

Proposal: Can we have an operator similar to https://lodash.com/docs/4.17.11#at #2740

minaseem opened this issue Dec 10, 2018 · 4 comments

Comments

@minaseem
Copy link
Contributor

No description provided.

@char0n
Copy link
Contributor

char0n commented Dec 10, 2018

You have it in ramda-adjunct : https://char0n.github.io/ramda-adjunct/2.13.0/RA.html#.paths

@CrossEye
Copy link
Member

CrossEye commented Dec 11, 2018 •
edited

While I'd love to hear some more feedback, it seems to me that this would complete the following chart:

Single node Multiple nodes
Scalar output prop path
Array output props ??

Obviously it's not essential. It's fairly simple to write as compose(juxt, map(path)), or to wrap that in uncurryN(2) if that exact API is wanted. But it does seem sensible to add.

@minaseem: Are you interested in creating a PR for this?

@Bradcomp
Copy link
Member

I think the name, per @char0n, should be paths rather than at to mirror props. Other than that this seems like a good idea to me.

minaseem added a commit to minaseem/ramda that referenced this issue Dec 12, 2018
@minaseem
feature: adding paths operator - ramda#2740
b2ac5c2
@minaseem minaseem mentioned this issue Dec 12, 2018
Merged
minaseem added a commit to minaseem/ramda that referenced this issue Dec 12, 2018
@minaseem
feature: adding paths operator - ramda#2740
c88cc04
@minaseem
Copy link
Contributor Author

@CrossEye Can you please review PR - #2742

minaseem added a commit to minaseem/ramda that referenced this issue Feb 7, 2019
@minaseem
feature: adding paths operator - ramda#2740
664d9ce
minaseem added a commit to minaseem/ramda that referenced this issue Feb 7, 2019
@minaseem
fixup! feature: adding paths operator - ramda#2740
c21098a
minaseem added a commit to minaseem/ramda that referenced this issue Feb 7, 2019
@minaseem
feature: adding paths operator - ramda#2740
5b99cd4
CrossEye pushed a commit that referenced this issue Feb 9, 2019
@minaseem @CrossEye
feature: adding paths operator - #2740 (#2742)
efd899b 
* feature: adding paths operator - #2740

* refactor: making path a derivative of paths

* refactor: making props a derivative of path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@CrossEye @char0n @minaseem @Bradcomp @wojpawlik