Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to transducer protocol. fixes #1003 #1006

Merged
merged 1 commit into from
Apr 5, 2015

Conversation

buzzdecafe
Copy link
Member

ping @kevinbeaty

please review! thanks

@@ -1,3 +1,7 @@
module.exports = function(x) {
return x && x.__transducers_reduced__ ? x : {value: x, __transducers_reduced__: true};
return x && x['@@transducer/reduced'] ? x :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, let's use:

return x != null && ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. i'll know that i have arrived when i get no review comments from you 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one doesn't really count, as the comment relates to code not modified in this pull request.

@kevinbeaty
Copy link
Contributor

@buzzdecafe Looks good to me. Thanks

@CrossEye
Copy link
Member

CrossEye commented Apr 5, 2015

🌿

@davidchambers
Copy link
Member

🌳

CrossEye added a commit that referenced this pull request Apr 5, 2015
update to transducer protocol. fixes #1003
@CrossEye CrossEye merged commit e51ea29 into ramda:master Apr 5, 2015
@buzzdecafe buzzdecafe deleted the xf-update branch April 23, 2016 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants