Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve perf of propEq and propIs #1748

Merged
merged 1 commit into from Apr 23, 2016
Merged

Conversation

benji6
Copy link
Contributor

@benji6 benji6 commented Apr 23, 2016

I think defining propEq and propIs in terms of propSatisfies is elegant, but having had problems using these functions on large lists I feel performance is probably more important.

I added a benchmark for propEq and had these results running locally:

# original definition
propEq("value", [1, 2… │ 368,588Hz │ 2.06% error margin

# new definition
propEq("value", [1, 2… │ 438,435Hz │ 1.79% error margin

Could add a benchmark for propIs too but I expect the results would be quite similar.

Let me know what you think

@davidchambers
Copy link
Member

🌳 Works for me!

@buzzdecafe
Copy link
Member

me too 🐄

@buzzdecafe buzzdecafe merged commit 96d8b42 into ramda:master Apr 23, 2016
@buzzdecafe
Copy link
Member

thanks

@benji6 benji6 deleted the perf-propEq-propIs branch April 23, 2016 07:09
@CrossEye
Copy link
Member

🌿

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants