Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xyz@1.0.x #1864

Merged
merged 1 commit into from Aug 12, 2016
Merged

xyz@1.0.x #1864

merged 1 commit into from Aug 12, 2016

Conversation

davidchambers
Copy link
Member

@@ -1,7 +1,6 @@
{
"name": "ramda",
"main": "dist/ramda.js",
"version": "0.22.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buzzdecafe
Copy link
Member

🐄

@buzzdecafe
Copy link
Member

🐪

@buzzdecafe buzzdecafe merged commit f79ffbb into ramda:master Aug 12, 2016
@davidchambers davidchambers deleted the xyz branch August 12, 2016 20:07
@davidchambers
Copy link
Member Author

Anyone who publishes Ramda should run rm -r node_modules && npm install. :)

@buzzdecafe
Copy link
Member

@davidchambers would it be overkill to add that to the publish flow?

@davidchambers
Copy link
Member Author

Something like this, do you mean?

 .PHONY: release-major release-minor release-patch
 release-major release-minor release-patch:
+   @rm -rf node_modules
+   @npm install
    @$(XYZ) --increment $(@:release-%=%)

We could certainly do so, though publishing would become slightly less satisfying. I'm don't mind one way or the other.

@buzzdecafe
Copy link
Member

yeah that's what i mean. i like it because it's one less thing to remember.

@davidchambers
Copy link
Member Author

xyz@1.0.0 is the first release since November 2014. It may well be another two years before the next release. So running rm -r node_modules && npm install is a once-every-year-or-two task rather than a run-before-publishing task. I would not even have mentioned it but for the change which means the "version" field in bower.json is no longer updated. Running an older version of xyz would reintroduce the "version" field removed in this pull request.

@buzzdecafe
Copy link
Member

i see. nm then :-)

@svozza
Copy link
Contributor

svozza commented Aug 15, 2016

Would npm prune achieve the same thing?

@davidchambers
Copy link
Member Author

Would npm prune achieve the same thing?

I don't think so. Its documentation says nothing about updating dependencies.

@svozza
Copy link
Contributor

svozza commented Aug 18, 2016

I meant in conjunction with npm install.

@davidchambers
Copy link
Member Author

I don't think npm install updates dependencies either. npm update does, but I've had problems with that command in the past. npm is a complex, bug-ridden piece of software. I rely on it as little as possible. ;)

@svozza
Copy link
Contributor

svozza commented Aug 19, 2016

Haha. Fair enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants