Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on reducing bundle size for Ramda. #2441

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

AndrewSouthpaw
Copy link
Contributor

@AndrewSouthpaw AndrewSouthpaw commented Jan 20, 2018

Based on discussion in several threads, including:

I figured it'd be a good idea to actually add some of this collective knowledge to the docs, since most people probably don't realize their bundle size may be bigger than they'd expect.

@CrossEye
Copy link
Member

This looks great to me. Thanks.

Anyone else have suggestions? @ramda/core ?

@JasonSooter
Copy link
Contributor

Does a distinction between using src and es directories need to be made?

@CrossEye
Copy link
Member

@JasonSooter: that's probably a good idea. Any specific suggestions?

@JasonSooter
Copy link
Contributor

@CrossEye Well, I don't really have any specific suggestions except maybe just adding that distinction in the cherrypicking section. I've been using the es directory because I have come to think that is the recommended way. And it seems to work fine for me. It also has stayed true to keeping bundle size to only imported functions after I setup module concatenation with Webpack. The only downside I have come across and that I have yet to dig into is that Flow cannot find types related to imported functions like it can if using import * as R from 'ramda' Let me know if I can be of any assistance.

Copy link
Member

@CrossEye CrossEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@CrossEye CrossEye merged commit 255565b into ramda:master Jan 22, 2018
@CrossEye
Copy link
Member

I'm going to merge as it is. If someone has a good suggestion for changes to document the use of es vs src, please open another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants