Update docs for memoizeWith #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R.memoize does not exist anymore. Update the documentation with no reference to R.memoize
|
Thank you. Good catch! |
Bradcomp
reviewed
Nov 26, 2018
| * create the cache key under which the results of the function to be memoized | ||
| * will be stored. Care must be taken when implementing key generation to avoid | ||
| * clashes that may overwrite previous entries erroneously. | ||
| * Takes an additional function that will be applied to a given argument set |
There was a problem hiding this comment.
Additional is no longer applicable here now that Memoize doesn't exist. Perhaps we should adapt the docs from memoize since we can't reference them anymore:
/**
* Creates a new function that, when invoked, caches the result of calling `fn`
* for a given argument set and returns the result. Subsequent calls to the
* memoized `fn` with the same argument set will not result in an additional
* call to `fn`; instead, the cached result for that set of arguments will be
* returned.
*/
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for memoizeWith was not updated when memoize was removed.
This PR simply removes the reference to memoize.