Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes jsdoc annotations for internal _Set class #2810

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pdeona
Copy link

@pdeona pdeona commented Apr 24, 2019

These changes attempt to fix the jsdoc type annotations for the internal _Set class and its associated methods.

Screen Shot 2019-04-25 at 12 25 29 AM

@pdeona pdeona force-pushed the jsdoc-fixes-internal-set branch 2 times, most recently from 16ecaa7 to fe382dd Compare April 25, 2019 04:06
@CrossEye
Copy link
Member

Very sorry @pdeona. A number issues from this period were entirely ignored. We're back and trying to get caught up. I'm curious about this one. I don't even know why that object has JSDoc tags, as it's not part of the public API. Do they get exposed through some JSDoc magic I don't know about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants