Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize prop or and path or functionality to match documentation #2995

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Tworley96
Copy link

Follow up to #2888
Reverts change to propOr that caused issue in test suite

@Tworley96 Tworley96 force-pushed the Standardize-propOr-and-pathOr-functionality-to-match-documentation branch from b9d0076 to d00ee74 Compare March 9, 2020 16:21
@ku8ar
Copy link
Contributor

ku8ar commented Mar 22, 2020

It all goes the wrong way. Adding nth support to prop/path causes unnecessary complexity. And it's very inefficient...

@CrossEye
Copy link
Member

CrossEye commented Mar 23, 2020

@ku8ar:

Do you have suggestions? I think the main constraints are that things like path(foo) and path([foo]) should always have the same behavior, and that all of these, but especially the simplest ones like path should be as performant as possible.

@ku8ar
Copy link
Contributor

ku8ar commented Mar 23, 2020

@CrossEye Yes of course. I added a suggestion here: #2974 (comment)
That suggestion will simplify this code. In short: remove nth from prop and path. But this is a hard decision, considering that there is already version 0.27 with this feature...

@CrossEye
Copy link
Member

I have absolutely no problem changing the behavior back in the next version if it turns our we made a mistake. I don't have much time now to investigate why this was added, and we need to do that before deciding whether it's worth the costs it adds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants