Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: curry: add warning about default parameters. close #3121 #3244

Merged

Conversation

customcommander
Copy link
Member

No description provided.

@adispring
Copy link
Member

adispring commented Feb 24, 2022

We can add this link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/length, to explain how curry/curryN calculate fn's length.

@customcommander customcommander force-pushed the docs-curry-default-params branch 2 times, most recently from 953b003 to 0f9bb60 Compare February 24, 2022 10:21
@customcommander
Copy link
Member Author

We can add this link: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/length, to explain how curry/curryN calculate fn's length.

Probably a good idea! Done.

adispring
adispring previously approved these changes Feb 24, 2022
Copy link
Member

@CrossEye CrossEye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, with one minor nit.

source/curry.js Show resolved Hide resolved
@customcommander customcommander merged commit aaffe72 into ramda:master Feb 26, 2022
@customcommander customcommander deleted the docs-curry-default-params branch February 26, 2022 19:03
@adispring adispring mentioned this pull request Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Currying with default argument values short-circuit currying
3 participants