Fix: cross-version placeholder support #3463
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3458
The strict equality operator means that
_isPlacerholder
works for only theR.__
from that specific install. If your project has multiple versions of ramda (which can easily happen due to npm semver resolution and^
versus~
versus exact inpackage.json
), you'll have problems.https://github.com/ramda/ramda/pull/3388/files#diff-cfb81eb9592aa5597e5aa32c6e449214f5b7eabeb172ad2447e2e537232454d2L2-R4
Reverting the logic back to what it was before is a looser check that will work cross-version