Path should return entire object for empty path #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
makes sense. 🐄 |
|
🌿 |
| @@ -5,7 +5,7 @@ var R = require('..'); | |||
|
|
|||
| describe('path', function() { | |||
| var deepObject = {a: {b: {c: 'c'}}, falseVal: false, nullVal: null, undefinedVal: undefined, arrayVal: ['arr']}; | |||
| it('takes a path and an object and returns the value at the path or undefined', function() { | |||
| it('takes a path and an object and returns the value at the path or the object', function() { | |||
There was a problem hiding this comment.
This wording change should be reverted. Your argument is that the object is the value at the path when the path is []. Also, the function does still return undefined if the path does not exist.
|
You're right David. I didn't think about that when changing the text. |
|
🌳 |
buzzdecafe
added a commit
that referenced
this pull request
Mar 30, 2015
Path should return entire object for empty path
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
_.path([], someObj)returnsundefined. This seems inconsistent to me. If you take zero steps down, you're still at the top.This modifies the internal
_pathfunction so that_.path([], obj)returns the passed in object and so that_.pathEq([], obj, obj) === true.This PR simply removes a special case in the code. This, I think, goes to show that the current behavior is inconsistent, i.e. it is not how a user would guess the function would be working.
If the current behavior was implemented with a good reason I'm sorry for this PR :)