Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(groupBy): return Partial Record #45

Merged
merged 5 commits into from
Jun 29, 2023

Commits on Jun 14, 2023

  1. fix(groupBy): return Partial Record

    The grouping classifier function may have never returned one of the
    possible values, so there is not necessarily an array for each group.
    
    Note: The test is sort of copied from DefinitelyTyped.
    I noticed you seem to use `tsd expect*` functions in the other test,
    but wanted to avoid putting a huge `expectType` of sorts.
    Testing this way seems like a pretty good idea here, because it's
    user-focused ('this expression with the groupBy result is allowed, this
    one is not').
    Feel free to amend the test if you don't like that part.
    jeysal committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    7436e44 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. switch the overload order and add support for __: Placeholder

    Co-authored-by: Harris Miller <harrismillerconsulting@gmail.com>
    jeysal and Harris-Miller committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b1522de View commit details
    Browse the repository at this point in the history
  2. placeholder test case

    jeysal committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b8b5713 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. add some tsd

    jeysal committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    46bf279 View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/develop' into groupby-partial

    * origin/develop:
      Update: Overload reordering (ramda#48)
      Update: count (ramda#40)
      Update: `of` now binary function (ramda#41)
      New: swap (ramda#42)
    jeysal committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    99ee949 View commit details
    Browse the repository at this point in the history