Update: take

[Harris-Miller]

Add curry support and fix issue with collapsing generic for dual function return when only passing a single argument
Added tests

[TClark1011]

Not sure if this matters for a typing package, but this is technically a breaking change for anyone who was calling the function like this: take(3)<number> since now that would have to be changed to take(3)<number[]>

[Harris-Miller]

Ohh good catch. That's fixable

[TClark1011]

Just thought of another problem; if the new curried signature is passed a tuple, the return type ends up being that exact tuple, which is not correct. You can see this on the g variable here https://tsplay.dev/w6Q5DW.

This can be fixed by changing the new overload signature to this:

export function take(
  n: number,
): <Collection extends readonly any[] | string>(
  xs: Collection,
) => Collection extends string ? string : Collection[number][];

Proof: https://tsplay.dev/w8Qo9N

This does have an interesting piece of behaviour though; the return type ends up being an array of all the literals that were contained in the tuple, eg; taking an items from a tuple of [1,2,3,4] returns the following (1 | 2 | 3 | 4)[] instead of number[]. Its subjective whether or not this is a bad thing, but this can also be avoided by creating a ToNonLiteral generic type, here is an example: https://tsplay.dev/NlXvrN.

[Harris-Miller]

Your ToNonLiteral we already have as WidenLiteral. You can find it in types/util/tools.d.ts

Both the issues you pointed out with this change make this MR a non-starter. Going to close

[TClark1011]

Dang, that's unfortunate, I'll keep looking into this, I feel like there's a way to get a perfect solution here somehow