Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logic to provide business information in apiDef #105

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

TomMaarschalkerweerd
Copy link
Collaborator

@TomMaarschalkerweerd TomMaarschalkerweerd commented May 10, 2023

🚨 Please review the guidelines for contributing to this repository.

In case businessInformation is provided in the apiDef, it takes the variables from your input. If not, it takes the input from the swagger definition as it is doing before this change.

  • Updated unit tests (*.spec.js)
  • Updated e2e tests (here)
  • Updated documentation (here)

🙌 Thank you!

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a6057fb) 81.52% compared to head (5368215) 81.64%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   81.52%   81.64%   +0.12%     
==========================================
  Files           3        3              
  Lines         590      594       +4     
  Branches       70       74       +4     
==========================================
+ Hits          481      485       +4     
  Misses         95       95              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ramgrandhi
Copy link
Owner

Thanks @TomMaarschalkerweerd for picking this up!

A few things:

  1. Please see code coverage errors are fixed. Adding a few unit tests should suffice.
  2. Make necessary changes to 2.6.0 as well, currently, it's done for 3.2.0 only.

@ramgrandhi ramgrandhi merged commit f37c25b into main Nov 14, 2023
5 checks passed
@ramgrandhi ramgrandhi deleted the feature_business_information_update branch November 14, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants