This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Fixed visitDate and visitTime methods to return date only or time only #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, parser works correctly with date-time only format, but do not respect date or time only while generating JSON schema. In any case it set date-time. Such behaviour causes an issue in future when this schema is used for POJO generation (such as jsonschema2pojo library or Mulesoft libs) etc. because in final POJO we always get LocalDateTime for all the cases. So when you try to serialize/deserialize such type - you always get yyyy-MM-dd T hh-mm-ss(etc) instead of just Date for date-only format for example. This causes errors while working with web-services
This PR is the fix for date and time only cases and there is no change for datetime-only case.
regards,
Eugene